Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: taskRnvHelp task #742

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Conversation

mmehtonen-24i
Copy link
Contributor

Description

This pr fixes rnv help command. This command currently throws a runtime failure as .getTasks() does not exist on engine data structure.

Note: it seems that unit tests at packages/rnv/__tests__/unitTests/cli.test.js are broken as all of them seem to give false positives. This is the reason why I didn't back this fix with tests. As for fixing those tests, I feel it would require a vast knowledge about internals of ReNative so I didn't attempt to do that.

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@pavjacko pavjacko added this to the 0.33 (Banshee) milestone Nov 20, 2021
@pavjacko pavjacko merged commit c2ccfd5 into flexn-io:develop Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants