Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS: Electron): Fixed macOS icons for electron engine #733

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

RicardasN
Copy link
Collaborator

Description

PNG format is also valid, so added support for that, what is more, ReNative templates were missing icon assignment to the app in macOS dock.

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

PNG format is also valid, so added support for that, what is more ReNative templates were missing icon assignment to the app in macOS dock.
@pavjacko pavjacko merged commit d903b85 into develop Nov 17, 2021
@pavjacko pavjacko deleted the fix/electron-macos-icons branch February 15, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants