Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/reset_overrides_on_bootstrap #1796

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

ElenaDiachenko
Copy link
Contributor

@ElenaDiachenko ElenaDiachenko commented Nov 21, 2024

Description

  • yarn bootstrap doesn’t revert overridden files to their original state after execution

Related issues

  • GH issues

Npm releases

n/a

Testing.

  • yarn bootstrap => the .rnv/overrides folder should be removed and patched packages should be reverted to their original state
  • alternative way: yarn resetOverrides ( npx rnv hooks run -x resetOverrides )

@ElenaDiachenko ElenaDiachenko self-assigned this Nov 21, 2024
@ElenaDiachenko ElenaDiachenko added the bug Something isn't working label Nov 21, 2024
@ElenaDiachenko ElenaDiachenko added this to the 1.8 milestone Nov 21, 2024
@ElenaDiachenko ElenaDiachenko added e2e and removed bug Something isn't working labels Nov 21, 2024
@pauliusguzas pauliusguzas requested review from pavjacko, pauliusguzas and Marius456 and removed request for pavjacko November 22, 2024 08:03
@pauliusguzas
Copy link
Collaborator

@ElenaDiachenko What app/platform combo utilises overrides? My current rnv monorepo has no overrides folder in .rnv

@ElenaDiachenko
Copy link
Contributor Author

@pauliusguzas Each platform uses overrides. You may not have this folder after yarn bootstrap clean

@pauliusguzas pauliusguzas merged commit b50b46d into main Nov 25, 2024
22 of 23 checks passed
@pauliusguzas pauliusguzas deleted the fix/reset_overrides_on_bootstrap branch November 25, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants