Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed wdio error #1008

Merged
merged 3 commits into from
Jun 19, 2023
Merged

fixed wdio error #1008

merged 3 commits into from
Jun 19, 2023

Conversation

mihaiblaga89
Copy link
Contributor

Description

fixed wdio error

@mihaiblaga89 mihaiblaga89 mentioned this pull request Jun 17, 2023
Closed
pauliusguzas
pauliusguzas requested changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-06-19 at 10 42 07 Getting still that typeerror as well as wdio error which makes no sense as it worked before, so I think that wdio error is related to that process error, wdio error catching is not the best

@pavjacko pavjacko changed the base branch from canary to main June 19, 2023 11:56
@pauliusguzas pauliusguzas self-requested a review June 19, 2023 15:13
pauliusguzas
pauliusguzas approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes should be done on other repos facing this issue, correct?

@mihaiblaga89
Copy link
Contributor Author

@pauliusguzas if there are more repos using the same then yes, just rename all the files from .js to .ts and it should work

@mihaiblaga89 mihaiblaga89 merged commit 0fca4c5 into main Jun 19, 2023
@mihaiblaga89 mihaiblaga89 linked an issue Jun 19, 2023 that may be closed by this pull request
Wdio config file fails to launch on template-starter package #978
Closed
@pavjacko pavjacko added this to the 0.37 milestone Jun 20, 2023
@pauliusguzas pauliusguzas deleted the fix/wdio branch June 21, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauliusguzas pauliusguzas pauliusguzas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.37
Development

Successfully merging this pull request may close these issues.

Wdio config file fails to launch on template-starter package
3 participants
@mihaiblaga89 @pauliusguzas @pavjacko