Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataflowGraph and fix part of substitutions #1449

Merged
merged 50 commits into from
Jul 31, 2024

Conversation

lockshaw
Copy link
Collaborator

@lockshaw lockshaw commented Jul 19, 2024

Description of changes:

Also adds proj doxygen support.

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:


This change is Reviewable

@lockshaw lockshaw added the repo-refactor Topics related to the repo and search refactors label Jul 19, 2024
@lockshaw lockshaw self-assigned this Jul 19, 2024
@lockshaw lockshaw changed the title Add DataflowGraph and fix substitutions Add DataflowGraph and fix part of substitutions Jul 25, 2024
@lockshaw lockshaw marked this pull request as ready for review July 26, 2024 22:11
@lockshaw lockshaw requested review from wmdi and Marsella8 July 26, 2024 22:11
@lockshaw lockshaw mentioned this pull request Jul 27, 2024
Copy link
Collaborator

@wmdi wmdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 304 of 493 files at r1, 263 of 445 files at r2, 170 of 181 files at r3, 16 of 16 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lockshaw and @Marsella8)


lib/substitutions/include/substitutions/substitution.h line 12 at r4 (raw file):

bool is_valid_substitution(Substitution const &);

SubParallelComputationGraph

Could you also add simple descriptions for the main functions? I feel like each time I need to recall their definition for a while.

Copy link
Collaborator Author

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 750 of 760 files reviewed, 1 unresolved discussion (waiting on @Marsella8, @reyna-abhyankar, and @wmdi)


lib/substitutions/include/substitutions/substitution.h line 12 at r4 (raw file):

Previously, wmdi (Mengdi Wu) wrote…

Could you also add simple descriptions for the main functions? I feel like each time I need to recall their definition for a while.

Added!

Copy link
Collaborator

@wmdi wmdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Marsella8 and @reyna-abhyankar)

wmdi
wmdi previously approved these changes Jul 31, 2024
Copy link
Collaborator

@wmdi wmdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Marsella8 and @reyna-abhyankar)

@lockshaw lockshaw merged commit 9b5902e into flexflow:repo-refactor Jul 31, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo-refactor Topics related to the repo and search refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants