-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataflowGraph
and fix part of substitutions
#1449
Conversation
DataflowGraph
and fix substitutions
DataflowGraph
and fix part of substitutions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 304 of 493 files at r1, 263 of 445 files at r2, 170 of 181 files at r3, 16 of 16 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lockshaw and @Marsella8)
lib/substitutions/include/substitutions/substitution.h
line 12 at r4 (raw file):
bool is_valid_substitution(Substitution const &); SubParallelComputationGraph
Could you also add simple descriptions for the main functions? I feel like each time I need to recall their definition for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 750 of 760 files reviewed, 1 unresolved discussion (waiting on @Marsella8, @reyna-abhyankar, and @wmdi)
lib/substitutions/include/substitutions/substitution.h
line 12 at r4 (raw file):
Previously, wmdi (Mengdi Wu) wrote…
Could you also add simple descriptions for the main functions? I feel like each time I need to recall their definition for a while.
Added!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Marsella8 and @reyna-abhyankar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Marsella8 and @reyna-abhyankar)
Description of changes:
Also adds
proj doxygen
support.Related Issues:
Linked Issues:
Issues closed by this PR:
This change is