Response body is not decoded correctly #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatibility with Ruby 2.0
|
Thanks @isabanin , this fixes a bug I encountered with an Amazon MWS gem which uses Net::HTTP when upgrading to Ruby 2. Could you update your pull request to something like so it doesn't break older rubies? |
|
Done. |
|
@konstantin-dzreyev any chance we can merge this? thanks (: |
|
acu142496 COMPLIANCE-COMMITMESSAGE-FIXED |
robertsulway
pushed a commit
that referenced
this pull request
Dec 3, 2013
Response body is not decoded correctly
|
Could we release a new gem version with this fix included? |
|
+1 |
|
+1 much needed |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changed the way Ruby decodes response body:
ruby/ruby@ddddf04
Without the line of code that I ported, gzip content from response body will not be automatically decoded. This will break gems such as postmark.