Merge tidy3d and docs no history
#1238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e action setup instructions
…e action setup instructions yaml link
… not working otherwise
… issue activating venv
… environment properly configured
…flex/tidy3d into repo_merge_no_history
|
Superseded by #1278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1231 and flexcompute-readthedocs/tidy3d-docs#321
Note that this is from a branch that carries on some of the commits of the poetry upgrade, but they are different branches so it's easier to upgrade or work in one or another direction accordingly
See #1234 too
Things that need to be done after the repos are merged: