gitlab: use HookActions map only if it is necessary #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herbetom
force-pushed
the
addApproveHookAction
branch
from
ffbd80a
to
dcee48e
Compare
herbetom
changed the title
|
Does it make sense to fallback to the raw value and not map values where |
|
Yes, that makes perfect sense. It's just more "complicated" to implement. |
herbetom
force-pushed
the
addApproveHookAction
branch
from
dcee48e
to
dc59103
Compare
herbetom
changed the title
|
@fleaz Could this work? |
herbetom
changed the title
herbetom
force-pushed
the
addApproveHookAction
branch
from
dc59103
to
dd0b3af
Compare
|
I changed the target branch. We will see if it works 🤷♂️ |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Gitlab 13.2 an approve and unapprove Action is available in Core: https://gitlab.com/help/user/project/merge_requests/merge_request_approvals#optional-approvals-core-only
The intent with this PR is to only use the Value form the HookAction if a value is found. Whether this is really what happens must be tested by someone. I have no environment in which I could easily test this.