Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new attributionwidget constructor #1393

Closed
wants to merge 1 commit into from
Closed

new attributionwidget constructor #1393

wants to merge 1 commit into from

Conversation

Friendly-Banana
Copy link

@Friendly-Banana Friendly-Banana commented Oct 28, 2022

fixes #1392
might become obsolete by #1390 but that is a draft as of now

@JaffaKetchup
Copy link
Member

Hi @Friendly-Banana,

Thanks for this PR, however, I am going to close it for three reasons:

  • There is already a way to construct a custom AttributionWidget - it doesn't create any of the UI for you, but it's not too hard to copy from the current implementation if necessary
  • This method of implementation creates a lot of code duplication - if it were to be accepted, it would be better to just have an argument to disable/remove the default text
  • Improve Attributions #1390 should be on the way relativley soon - we are still in discussion on the Discord server (note that it may or may not become a plugin: we are still undecided, and it will depend on the extent to which the PR goes). Whilst it won't replace this current method of attribution, it should resolve the issues you mentioned in your original issue ([FEATURE] new AttributionWidget without default text #1392).

Please don't be dissuaded from contributing in the future: we are always happy to have new ideas and PRs! Once again, many thanks for your PR!

@Friendly-Banana
Copy link
Author

H @JaffaKetchup,
Ok, I understand. Looking forward to #1390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] new AttributionWidget without default text
2 participants