Implement token revocation #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A6GibKm
reviewed
Apr 1, 2023
| args: Json<TokenArgs>, | ||
| db: Data<Db>, | ||
| req: HttpRequest, | ||
| ) -> impl Future<Item = HttpResponse, Error = ApiError> { |
There was a problem hiding this comment.
Any reason to not use the async keyword? It does more than just being eye candy.
There was a problem hiding this comment.
We are using a very old version of Actix that uses futures 0.1, so the extra functions convert from std futures to the old ones with .compat().
| token_ids: Vec<String>, | ||
| } | ||
|
|
||
| pub fn get_tokens( |
There was a problem hiding this comment.
As Jamie pointed out, this is just as async as the other function, why have two?
|
I would appreciate if we could land #92 so we don't have to keep adding more "old" way of doing things from diesel side. |
jameswestman
force-pushed
the
token-revocation
branch
from
002ab9f
to
5d2d299
Compare
This will allow us to check the database for revocations.
Check the database to see if a token ID has been revoked. Also, record the timestamp of the last time a token is used, to help debugging. Also added a "tokenmanagement" scope and endpoints to list tokens and revoke them.
jameswestman
force-pushed
the
token-revocation
branch
from
5d2d299
to
6b308f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tokens with a "jti" field, query the database to see if the token has been revoked. Also, log the time it was last used, to help debug and/or recognize suspicious activity.
There are two new endpoints, to list tokens (so the backend can show the last used time and whether a token is revoked) and to revoke tokens. The idea is for the backend to keep its own record of which tokens belong to which users, and invoke these endpoints on their behalf with its own token.
I've also added a config option to allow tokens to be prefixed. This makes it easier to recognize tokens that have been accidentally published.