Tab content should be moved, not replicated.

[constantm]

Tab content should ideally be moved dynamically instead of just being replicated. Replicating it is fine if the content of the tab doesn't include any elements with IDs or forms which JS interacts with.

[okendoken]

@constantm I didn't really get the difference between "replicated dynamically" and just "replicated". Could you please explain a bit more here?

Thanks

[constantm]

Ah sorry. "Replicated dynamically" should have been "moved dynamically". I've updated the original issue.

[okendoken]

Here is the way it's currently done (line 106):

$panel.find('.panel-body').append($tabPane.children('*').detach())

Do we call it "replicated" or "moved"? I believe it's more appropriate to call it "moved", isn't it?

[constantm]

The problem is that it keeps the "old" version in the DOM, which causes issues with duplicate IDs and jQuery bindings. An example of this would be doing something simple like $('#element_id').val(), which would find and return the first element, which would be hidden when the mobile accordion is visible.

[okendoken]

Seems like I am missing something really obvious :(
Still didn't get your point. Could you please make an example code of it?

Thanks

[constantm]

Okay, will do as soon as I have a minute!

[julianxhokaxhiu]

@constantm I think you're using an old version or a buggy one of jQuery. Mine is moving perfectly and it's not keeping any "old" shadow of it in the DOM. If so, it's a jQuery bug (and browser compatibility related), not of this plugin itself.

[constantm]

That's awesome to hear. I've not really looked at this again since September of last year, but will probably need to do so sooner rather than later. :)