Use base extension with pre-built static libraries #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This base extension contains pre-built static libraries for zlib, liblzma, libzstd and libarchive, meaning we don't have to download and compile these libraries for every version we package. The speed gain is massive: Without this extension, packaging 5 different driver versions on my personal computer (quad-core CPU @ 3.6 GHz) took a whopping 6 minutes. With the base extension, the same packaging process took only 23 seconds, almost 16 times faster!
|
Started test build 171681 |
|
Build 171681 failed |
|
Production driver 550.144.03 was released today, so it's time to merge this. |
|
There's been a 3-hour reduction in build time! Before this PR: https://buildbot.flathub.org/#/builders/6/builds/170856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This base extension contains pre-built static libraries for zlib, liblzma, libzstd and libarchive, meaning we don't have to download and compile these libraries for every version we package.
The speed gain is massive: Without this extension, packaging 5 different driver versions on my personal computer (quad-core CPU @ 3.6 GHz) took a whopping 6 minutes.
With the base extension, the same packaging process took only 23 seconds, almost 16 times faster!
Marking as draft for now, though, because I intend to merge this when NVIDIA releases their next driver - just to avoid releasing multiple updates needlessly and annoying users.
Collaborators, feel free to review or question these changes in the meantime.