Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Omaha sha1 hash if available and Verify checksum after download, with retry #47

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Check Omaha sha1 hash if available and Verify checksum after download, with retry #47

merged 4 commits into from
Jan 5, 2024

Commits on Jan 5, 2024

  1. Check Omaha sha1 hash if available 

    Old Nebraska servers were missing the newly introduced sha256 attribute
and might only serve paylads with the regular sha1 attribute set. The
generic payload is also just using the regular sha1 attribute because
at that time a different extension was used which holds the sha256
checksum for the generic payload.
Support the regular Omaha sha1 hash for use with old Nebraska servers.
This makes it also easy to test with the generic payload.
    @pothos
    pothos committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    661d1b8 View commit details
    Browse the repository at this point in the history

  2. Verify checksum after download, with retry 

    The self.verify_checksum(...) call's return value wasn't checked in the
package download call. Even if we do it there we should rather move it
into the retry loop and make it explicit whether we expect certain
checksums or not.
Check the checksum after the download, and also retry when it
mismatches.
    @pothos
    pothos committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    887994b View commit details
    Browse the repository at this point in the history

  3. Fix clippy warnings for non-vendored crates, disable on vendored crates

    @pothos
    pothos committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    4a5a55f View commit details
    Browse the repository at this point in the history

  4. .github: Run clippy on CI

    @pothos
    pothos committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    e9a158b View commit details
    Browse the repository at this point in the history