Switch to reqwest::blocking #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please |
dongsupark
approved these changes
Dec 21, 2023
The use of async for the client was motivated by doing hashing while downloading and ideally everything else too so it would extract to disk. However, only the hashing was done and all other operations including and additional hash step were done on the file. Since the use of async brought more problems while not having a real benefit, switch to a blocking mode. Instead of opening the file and passing a write to the download function we now open the file inside the download function which will make it easier to retry downloads.
|
Yes, have removed Tokio as direct dependency but it is still used by reqwest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work :)
How to use
Agree if we want to use this
Testing done
Downloading with a direct URL and with the XML works. I also checked that the download is done to disk and there is no copy in RAM (/usr/bin/time -v shows the Maximum resident set size to be 24 MB for the full Flatcar update payload which is 370 MB).