Skip to content

Commit

Permalink
nvidia-runtime: Address review
Browse files Browse the repository at this point in the history
- fix typo
- switch to ubuntu 20.04
- add extension to README
  • Loading branch information
jepio committed Sep 3, 2024
1 parent 9577961 commit 75ab117
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ For extensions that are not part of the GitHub Release or which you want to cust
| `kubernetes` | released |
| `docker` | released (includes containerd) |
| `docker_compose` | released |
| `nvidia-runtime` | released |
| `wasmtime` | released |
| `wasmcloud` | released |
| `tailscale` | released |
Expand Down
10 changes: 5 additions & 5 deletions create_nvidia_runtime_sysext.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ SCRIPTFOLDER="$(dirname "$(readlink -f "$0")")"

if [ $# -lt 2 ] || [ "$1" = "-h" ] || [ "$1" = "--help" ]; then
echo "Usage: $0 VERSION SYSEXTNAME"
echo "The script will build nvidia-container-toolkit on ubuntu 18 and package it into a syseext."
echo "The script will build nvidia-container-toolkit on ubuntu 20 and package it into a sysext."
echo "A temporary directory named SYSEXTNAME in the current folder will be created and deleted again."
echo "All files in the sysext image will be owned by root."
echo "To use arm64 pass 'ARCH=arm64' as environment variable (current value is '${ARCH}')."
Expand All @@ -29,15 +29,15 @@ fi
git clone -b ${VERSION} --depth 1 https://github.com/NVIDIA/libnvidia-container || true
git clone -b ${VERSION} --depth 1 https://github.com/NVIDIA/nvidia-container-toolkit || true

make -C libnvidia-container ubuntu18.04-${ARCH}
make -C nvidia-container-toolkit ubuntu18.04-${ARCH}
make -C libnvidia-container ubuntu20.04-${ARCH}
make -C nvidia-container-toolkit ubuntu20.04-${ARCH}

rm -rf "${SYSEXTNAME}"
mkdir -p "${SYSEXTNAME}"
for deb in libnvidia-container/dist/ubuntu18.04/${ARCH}/libnvidia-container{1_*,-tools_}*.deb; do
for deb in libnvidia-container/dist/ubuntu20.04/${ARCH}/libnvidia-container{1_*,-tools_}*.deb; do
dpkg-deb -x $deb "${SYSEXTNAME}"/
done
for deb in nvidia-container-toolkit/dist/ubuntu18.04/${ARCH}/nvidia-container-toolkit*.deb; do
for deb in nvidia-container-toolkit/dist/ubuntu20.04/${ARCH}/nvidia-container-toolkit*.deb; do
dpkg-deb -x $deb "${SYSEXTNAME}"/
done
rm -rf "${SYSEXTNAME}"/usr/share
Expand Down

0 comments on commit 75ab117

Please sign in to comment.