oem_sysext_util: Mount overlay on top of /usr before installing sysext #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t packages After changes to the inode size, the sysext installation runs out of space because the installation happens on a mounted production image. This is problematic because the /usr partition is only 1024MB in size and gets full. Mount a temporary overlay so that we can use that for installation, and discard it afterwards. This also means we no longer need to disable verity and in fact could live without copying the prod image. I won't make that change since we're working on a new script to automate building of sysexts using the overlay approach. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
Jenkins build of azure images here: http://192.168.42.7:8080/job/container/job/packages_all_arches/2041/cldsv/. |
Test report for 3643.0.0+nightly-20230622-2100 / amd64 arm64Platforms tested : qemu_uefi-amd64 qemu_update-amd64 qemu_uefi-arm64 qemu_update-arm64
Diagnostic output for qemu_uefi-arm64, run 4Diagnostic output for qemu_uefi-arm64, run 3Diagnostic output for qemu_uefi-arm64, run 2Diagnostic output for qemu_uefi-arm64, run 1
|
krnowak
approved these changes
Jun 23, 2023
|
jenkins CI is failing: not sure why. |
The SDK container bind mounts __build__/images to the containers image directory, but the CI uses a different path for images. This causes issues when building the oem sysext, because it requires mounting an overlayfs. The current path (~/build/...) is an overlayfs and an ovlerayfs can't be an upper directory. Align the CONTAINER_IMAGE_ROOT and CONTAINER_TORCX_ROOT values with standard practices to that oem sysext building in jenkins ci works. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
Looks like the images directory was located in an overlayfs, i've fixed that here and rerunning jenkins: 6ebbe5f. |
Interesting, my openssh PR (which is rebased on top of this PR) went through the Jenkins build just fine. |
jepio
force-pushed
the
jepio-fix-oem-sysext
branch
from
b7d908f to
b40c1f2
Compare
jepio
force-pushed
the
jepio-fix-oem-sysext
branch
from
b40c1f2 to
9b339f2
Compare
`build_image` depends on accesss to the torcx manifest and the "content addressable nature" of the directory. We currently rely on the torcx output root structure being preserved in the container image. While we're moving the torcx output root out of the container image, preserve its contents so that they can be restored from bincache.
jepio
force-pushed
the
jepio-fix-oem-sysext
branch
from
9b339f2 to
1fc599f
Compare
|
@krnowak Finally have a working version, please take a look. Proof of success here: http://192.168.42.7:8080/job/container/job/packages_all_arches/2054/cldsv/. |
krnowak
approved these changes
Jun 28, 2023
jepio
added a commit
that referenced
this pull request
Jun 28, 2023
oem_sysext_util: Mount overlay on top of /usr before installing sysext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount overlay on top of /usr before installing sysext
This fixes the issue of sysext creating running out of disk space after we changed the ext4 inode size to 256 bytes.
How to use
Testing done
Performed the step in
how to use- successfully.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.