Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-kernel/bootengine: pull ignition changes #2308

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Sep 11, 2024

this pulls Ignition reordering to fix Equinix Metal issues. (flatcar/bootengine#99) (upstream: coreos/ignition#1940)


Ignition will POST a status update to Equinix Metal at each stage (disk, mount, files, etc.). The failure occurs in mount service, because systemd-networkd is shutted down, as all other services because initrd-cleanup.service is started.
initrd-cleanup.service is started because Ignition has reported success (last stage files is executed with success) so the Ignition complete target is reached.

But the mount service has an ExecStop condition:

ExecStop=/usr/bin/ignition --root=/sysroot --platform=${PLATFORM_ID} --stage=umount ${IGNITION_ARGS}

which will fail on Equinix Metal because as said: we need the network to POST updates to Equinix Metal

Testing done

Related to: flatcar/Flatcar#1536

this pulls Ignition reordering to fix Equinix Metal issues.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 marked this pull request as ready for review September 16, 2024 07:52
@tormath1 tormath1 requested a review from a team September 16, 2024 07:52
@tormath1 tormath1 merged commit 7234433 into main Sep 16, 2024
1 check failed
@tormath1 tormath1 deleted the tormath1/ignition branch September 16, 2024 12:21
@tormath1
Copy link
Contributor Author

cherry-picked to:

For Stable, I'm still considering if we should or not create a backport branch on bootengine to avoid shipping the PXE/ISO fix in Stable directly.

Copy link

Build action triggered: https://github.com/flatcar/scripts/actions/runs/10883888286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants