-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config/env/sys-fs/zfs-kmod: un-break zfs-kmod binpkg install #2260
Conversation
This change sets SKIP_KERNEL_BINPKG_ENV_RESET in the zfs-kmod env so linux-info.eclass keeps kernel env variables. This resolves an issue with installing zfs-kmod as a binpkg when the kernel was not yet installed. In a pure binpkg install the zfs-kmod package might be installed before the kernel, leading to the kmod's kernel version detection to fail. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
50959ad
to
3c9f90f
Compare
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10630574877 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the function below (cros_pre_pkg_setup_kernel_version
) still useful with this change?
That's a good question - I'm not really close to this part of our eclasses. We might want to simply try removing it in a follow-up PR and see what happens... |
config/env/sys-fs/zfs-kmod: un-break zfs-kmod binpkg install
config/env/sys-fs/zfs-kmod: un-break zfs-kmod binpkg install
config/env/sys-fs/zfs-kmod: un-break zfs-kmod binpkg install
Merged to main and cherry-picked to flatcar-3975, flatcar-4012, and flatcar-4054. |
This change sets
SKIP_KERNEL_BINPKG_ENV_RESET
in the zfs-kmod env so linux-info.eclass keeps kernel env variables. This resolves an issue with installing zfs-kmod as a binpkg when the kernel was not yet installed. In a pure binpkg install the zfs-kmod package might be installed before the kernel, leading to the kmod's kernel version detection to fail.The original issue may be reproduced by running a rebuild of a release tag (which will use binpkgs from our mirrors). Note that the reproduction is flaky because the issue is caused by a race condition between installing the kernel binpkg and zfs-kmod.
How to use
docker container prune
between runs so the build starts from scratch.Testing done
Ran the above builds.
Cherry-pick / backport
Should be cherry-picked to all maintenance branches that ship the zfs sysext (i.e. all except LTS):
flatcar-3975
flatcar-4012
flatcar-4054