Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-firewall/conntrack-tools: remove obsolete 1.4.5 #2258

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

t-lo
Copy link
Member

@t-lo t-lo commented Aug 27, 2024

This change removes an outdated conntrack-tools ebuild - version 1.4.5 - from maintenance branch flatcar-4054. The branch uses 1.4.6-rc1 anyways so the legacy ebuild can safely be deleted.

This ebuild uses EAPI 6 and will cause a transient error message during build. It imports the linux-info eclass which was recently updated to only support EAPI 7 and higher. This will cause emerge to print an error message when considering the 1.4.5 ebuild. While that error message has no impact on the build because 1.4.6-rc1 is more recent and will hence be used, it can be misleading when investigating unrelated issues (which it did to me, hence this patch).

How to use

  • Check out this branch
    git clone https://github.com/flatcar/scripts.git
    cd scripts
    git checkout t-lo/flatcar-4054-remove-conntrack-1.4.5
  • Build it
    ./run_sdk_container -t
           ./build_packages
           ./build_image
    

Testing done

Built the image (see above), built qemu uefi image, ran tests locally.

@t-lo t-lo requested a review from a team August 27, 2024 16:55
@chewi
Copy link
Contributor

chewi commented Aug 27, 2024

Please update the Manifest too. I know we don't run QA tools that would check that but...

Copy link

github-actions bot commented Aug 27, 2024

Build action triggered: https://github.com/flatcar/scripts/actions/runs/10595671568

@t-lo
Copy link
Member Author

t-lo commented Aug 27, 2024

Please update the Manifest too. I know we don't run QA tools that would check that but...

You're right! Good catch, will update. We should make use of these QA tools one day...

This change removes an outdated conntrack-tools ebuild - version 1.4.5 -
from maintenance branch flatcar-4054. The branch uses 1.4.6-rc1 anyways
so the legacy ebuild can safely be deleted.

This ebuild uses EAPI 6 and will cause a transient error message during
build. It imports the linux-info eclass which was recently updated to
only support EAPI 7 and higher. This will cause emerge to print an
error message when considering the 1.4.5 ebuild. While that error
message has no impact on the build because 1.4.6-rc1 is more recent and
will hence be used, it can be misleading when investigating unrelated
issues (which it did to me, hence this patch).

Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
@t-lo t-lo force-pushed the t-lo/flatcar-4054-remove-conntrack-1.4.5 branch from 44d5c7c to 8644d6c Compare August 27, 2024 17:03
@t-lo
Copy link
Member Author

t-lo commented Aug 28, 2024

Tests are green except for extra-test.[first_dual].cl.update.oem which is currently broken; tracked in flatcar/Flatcar#1518. Very likely unrelated. Merging.

@t-lo t-lo merged commit 9ddfe11 into flatcar-4054 Aug 28, 2024
5 of 7 checks passed
@t-lo t-lo deleted the t-lo/flatcar-4054-remove-conntrack-1.4.5 branch August 28, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants