Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-kernel/bootengine: Bump to fix slow PXE/ISO boots with udev rule #2249

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Aug 22, 2024

sys-kernel/bootengine: Bump to fix slow boots with udev rule

See: flatcar/bootengine#98
See: flatcar/Flatcar#1514

How to use

See: flatcar/bootengine#98

Testing done

Lots of manual testing and a packages_all_arches Jenkins job, as mentioned in the other PR. I'll do a GitHub run for this PR.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@chewi chewi requested a review from a team August 22, 2024 11:05
@chewi chewi self-assigned this Aug 22, 2024
Copy link
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tip: I usually avoid using Closes: tags in commit messages/PRs, and prefer cross-referencing with See:. The issue has now been closed even though we haven't merged the scripts PR yet. Even after this PR is merged, we'd still need to backport to stable-3975 (because that's where the issue was spotted) before we can consider the issue closed. Sometimes it even makes sense to wait until a release has been done.

Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this needs backporting to other channels, make sure you don't backport additional changes in bootengine by accident. If other channels were using different commit for bootengine, we will need to create backport branches in baselayout that contain your fix only.

Copy link

github-actions bot commented Aug 22, 2024

Build action triggered: https://github.com/flatcar/scripts/actions/runs/10955901407

@chewi chewi merged commit 95acc13 into main Aug 22, 2024
7 checks passed
@chewi chewi deleted the chewi/decrypt-root-udev branch August 22, 2024 15:49
chewi added a commit that referenced this pull request Aug 29, 2024
sys-kernel/bootengine: Bump to fix slow PXE/ISO boots with udev rule
@tormath1
Copy link
Contributor

tormath1 commented Sep 5, 2024

I just noticed that this change has been backported to the previous beta (flatcar-4012) but we forgot to backport it on previous alpha (flatcar-4054) which has been promoted to current beta - we might need to backport it again to current beta (flatcar-4054) in case we push a maintenance release for beta channel.

@chewi
Copy link
Contributor Author

chewi commented Sep 5, 2024

Oh, sorry about that. Still getting my head around this. I thought alpha just tracked main. Err, I think it does track main, but that's not the point. 😅

@tormath1
Copy link
Contributor

I just noticed that this change has been backported to the previous beta (flatcar-4012) but we forgot to backport it on previous alpha (flatcar-4054) which has been promoted to current beta - we might need to backport it again to current beta (flatcar-4054) in case we push a maintenance release for beta channel.

Cherry-picked to flatcar-4054

@tormath1
Copy link
Contributor

Cherry-picked to flatcar-3975 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants