-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-automation: add hetzner testing #2142
Conversation
a13c700
to
f165746
Compare
f165746
to
24fb307
Compare
ci-automation/ci-config.env
Outdated
|
||
# -- Hetzner -- | ||
: ${HETZNER_IMAGE_NAME:='flatcar_production_hetzner_image.bin.bz2'} | ||
: ${HETZNER_amd64_INSTANCE_TYPE:="cx22"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cx
plans have limited availability. To reduce flaky pipelines I would recommend cpx11
instead.
https://status.hetzner.com/incident/aa5ce33b-faa5-4fd0-9782-fde43cd270cf
- Title: Limited availability of CX plans
- Status: In progress
- Start: 2024-06-17 10:00 UTC+0
- Description: Due to increased demand, instances on CX plans (CX22 to CX52) are currently subject to limited availability.
We will gradually release new capacities as soon as they are available.
45e04ec
to
32a7b25
Compare
80837f3
to
deeefa0
Compare
deeefa0
to
cebdf2b
Compare
@apricote AMD tests look perfect but ARM tests are not happy:
With:
For the other tests, I will try to repro. |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10768868921 |
@tormath1 Can you try again with the patches from flatcar/mantle#553? It works now for me on |
cebdf2b
to
4045873
Compare
@apricote All good now - a bit flaky on the Kubernetes test but I think it was transient:
|
--fail-with-body \ | ||
--retry 2 \ | ||
--silent \ | ||
--user-agent "flatcar-ci/unknown" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment about why we override the user agent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apricote any idea why we need this? I see it's similar to this: https://github.com/hetznercloud/tps-action/blob/dee5dd2546322c28ed8f74b910189066e8b6f31a/get-token.sh#L19 but not sure why we need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a debugging aid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works without the user agent. Having the user agent in requests is helpful for us operating the service as we can easily figure out who is affected by any errors, who is sending too many requests...
Of course, the user agent can easily be faked by anyone, so we don't fully rely on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @apricote for sharing the details. Let's keep the user agent like this in this case as it can help you to monitor the TPS system.
No need for garbage collection since one temporary project is allocated with 1h of lifespan for each run. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com> Co-authored-by: Julian Tölle <julian.toelle97@gmail.com>
4045873
to
ce763ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user-agent issue is a minor thing. Regardless of whether it gets removed or not, the PR looks good.
cherry-picked to:
|
In this PR, we bring the "glue" between Flatcar CI and Hetzner Mantle implementation.
NOTE: For this specific cloud provider there is no need to implement garbage collection as the provider is providing us a temporary project to run our tests, the project is deleted right after
Testing done
CI 🟢 : http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/4600/cldsv/
Closes flatcar/Flatcar#1412