Generate test update payload and run the kola update test #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kola update tests need a dev-key-signed update payload. This was lacking and caused the update tests to be skipped. Generate the test update payload for both dev builds and release builds and run the kola tests for both. The test update payload has a special name to not confuse it with the real update payload for releases, and we keep the previous behavior to sign releases. Therefore, the generate_update function wasn't used but the extract_update function extended with generating the additional test payload.
pothos
added a commit
that referenced
this pull request
Jul 14, 2021
Generate test update payload and run the kola update test
pothos
added a commit
that referenced
this pull request
Jul 14, 2021
Generate test update payload and run the kola update test
pothos
added a commit
that referenced
this pull request
Jul 14, 2021
Generate test update payload and run the kola update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kola update tests need a dev-key-signed update payload. This was
lacking and caused the update tests to be skipped.
Generate the test update payload for both dev builds and release builds
and run the kola tests for both. The test update payload has a special
name to not confuse it with the real update payload for releases, and
we keep the previous behavior to sign releases. Therefore, the
generate_update function wasn't used but the extract_update function
extended with generating the additional test payload.
How to use
This replaces #98
Depends on flatcar/mantle#187 and flatcar/mantle#189
In a follow-up PR I plan to add testing to update from the last release in addition.
Note: Should be picked for all channels.
Testing done
http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3028/cldsv/
First the kola test failed because it did not find the
coreos-setgoodrootcommand, this is fixed in flatcar/mantle#187 and then arm64 failed because the timeout was too strict, this is fixed in flatcar/mantle#189Tested locally and by rerunning the Jenkins qemu jobs