fix(frontend:e2e): update tests and snapshots #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed redundant test setup for application creation dialog in `global.setup.ts`. - Updated screenshot masking in `instance.spec.ts` to include additional elements, improving test reliability. - Updated snapshot images for `instance-history` and `instance-info` to reflect changes.
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
tormath1
approved these changes
Feb 13, 2025
Yes, if we make a screenshot of the pages where the status of the instances is timestamped now, tomorrow they will be different. Also, it is not predictable how much time it takes for the test suit to perform certain actions, for example to create entities, therefore just masking these values seems to be an easier and more reliable solution than trying to fix the datetime values in the database. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update flaky tests and snapshots due
global.setup.ts.instance.spec.tsto include additional elements, improving test reliability.instance-historyandinstance-infoto reflect changes.Testing done
Executed the e2e locally a dozen times.