Update Packet API to lastest version #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also needs a new SSH client option. Other vendored files were deleted by "make vendor".
pothos
force-pushed
the
kai/update-packngo
branch
from
0b20000 to
74a7382
Compare
pothos
force-pushed
the
kai/update-packngo
branch
from
efcc830 to
45c33d0
Compare
pothos
force-pushed
the
kai/update-packngo
branch
from
ffd052f to
4be942e
Compare
pothos
force-pushed
the
kai/update-packngo
branch
2 times, most recently
from
d6db5ad to
1cbb9e2
Compare
pothos
force-pushed
the
kai/update-packngo
branch
2 times, most recently
from
9c49a63 to
97b57fb
Compare
|
I need to make the loop cover the rest of the function so that if |
After coreos/bugs#2065 a test for "excessive bonding link status messages" was introduced which also is good to keep for coreos/bugs#2374. However, having this message printed 10 times does not directly relate to an error. The test should check if something like 'bond0: Gained carrier' or 'link status definitely up for interface enp0s20f0' is coming at the end and then continue. Add a second match for these messages that skips the test. Also lower the threshold to see if the logic works well.
pothos
force-pushed
the
kai/update-packngo
branch
from
38a274f to
fcdfc46
Compare
|
Done |
t-lo
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Packet API to latest version
Porting needs a new SSH client option. Other vendored files were deleted by "make vendor".
Retry on provisioning timeouts
Improve bonding check and lower threshold
After Kernel 4.12 breaks non-zero updelay in network bonding driver coreos/bugs#2065
a test for "excessive bonding link status messages"
was introduced which also is good to keep for
Network bonding driver fails to enable interface, spams log coreos/bugs#2374.
However, having this message printed 10 times
does not directly relate to an error.
The test should check if something like
'bond0: Gained carrier' or
'link status definitely up for interface enp0s20f0'
is coming at the end and then continue.
Add a second match for these messages that skips
the test. Also lower the threshold to see if the
logic works well.