kola: remove cmdline parameters for Tang and TPM tests #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2024
pothos
reviewed
Mar 25, 2024
pothos
reviewed
Mar 25, 2024
|
Thanks! When we backport your bootengine changes this will even work for the old Alpha, but maybe we should still bump the minimum image version for the test to be |
simoncampion
force-pushed
the
remove-luks-cmdline
branch
from
209ba02 to
930be7c
Compare
Sounds good, I bumped the min version to 3913.0.1. |
pothos
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove kernel cmdline parameters for Tang and TPM tests
Removes
rd.luks...cmdline parameters that are unnecessary once this PR in flatcar/bootengine is merged. Removing the cmdline parameters should also fix an issue with tests failing because of failing superfluoussystemd-cryptsetupunits during the first boot.How to use
Run the
cl.tpm.*andcl.tang.*tests.Testing done
See the description of testing done in this PR.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.