-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kola/tests/tang: Ignore interfaces with no IPs #509
Conversation
We use Equinix Metal machines in our CI that have bonded network interfaces, which means we end up with nics with no ips. The tang setup code needs to handle this. We will also want to rework the code to provide tang in the same way as we do for etcd. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
log.Fatalf executes os.Exit. We don't want the whole kola process to exit if the port is busy, only the test case should fail. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
To prevent conflicts between test cases and jobs. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
These don't work in nspawn/docker and spam the console with "not permitted" errors. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
I think we can also remove the The run on first boot seems to fail due to a race but the system boots ok, and the second boot has no error messages:
|
For arm64 I prepared a PR: flatcar/scripts#1755 |
Thanks for fixing this, @jepio ! Regarding the failing service: I should've run the tests on arm64 locally, then I would have caught the issue before the merge. Sorry about that, I completely forgot about arm64. I think the issue is that we need the We could fix this issue by changing the Ignition config in the tests so that the Regarding the masking: Yep, the masking might be unnecessary now. I am relatively sure it doesn't make the tests fail at the moment though, so I'd suggest we get the arm64 tests to pass first and then I'll check whether tests still pass without the masking and open a PR if they do. |
We use Equinix Metal machines in our CI that have bonded network interfaces, which means we end up with nics with no ips. The tang setup code needs to handle this. We will also want to rework the code to provide tang in the same way as we do for etcd.