Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iovisor/bcc: add Docker image build/push workflow #489

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

ader1990
Copy link
Contributor

  • Added .github/workflows/build-push-iovisor-bcc.yaml workflow to build and push the image to ghcr.io/flatcar/bcc:latest
  • Switch to the ghcr.io/flatcar/bcc:latest image instead of the quay.io/iovisor/bcc image

Until PR iovisor/bcc#4845 is merged or the issue iovisor/bcc#4842 is addressed, we need to use the branch with required fix to changelog and python3 modules.

@ader1990
Copy link
Contributor Author

To see that the build works - I have created a small test repo with just this action here: https://github.com/ader1990/flatcar-mantle-bcc-build/actions/runs/7222588929/job/19679858014

kola/tests/bpf/bpf.go Outdated Show resolved Hide resolved
kola/tests/bpf/bpf.go Outdated Show resolved Hide resolved
  * Added .github/workflows/build-push-iovisor-bcc.yaml workflow to
    build and push the image to ghcr.io/flatcar/bcc:latest
  * Switch to the ghcr.io/flatcar/bcc:latest image instead of the
    quay.io/iovisor/bcc image

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
@@ -40,8 +40,6 @@ func init() {
// required while SELinux policy is not correcly updated to support
// `bpf` and `perfmon` permission.
Flags: []register.Flag{register.NoEnableSelinux},
// exclude `arm64` while `quay.io/iovisor/bcc` does not have `arm64` support.
Architectures: []string{"amd64"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change might break the CI as the arm64 workflow has not been run before.

@pothos pothos merged commit 46dbc15 into flatcar:flatcar-master Dec 15, 2023
@pothos
Copy link
Member

pothos commented Dec 15, 2023

I've started the workflow: https://github.com/flatcar/mantle/actions/runs/7223728739
When finished we can (trigger and) merge the mantle container ref PRs in the scripts repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants