Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: support docker in portage stable, add support for docker 24 #471

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

t-lo
Copy link
Member

@t-lo t-lo commented Oct 25, 2023

This PR contains fixes for tests to add support for testing docker version 24. Docker 24 changes a number of defaults that cause issues with tests.

Required for flatcar/scripts#1305, part of flatcar/Flatcar#1091.

Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
This change adds an explicit brtfs driver request in
/etc/docker/daemon.json to un-break the docker btrfs test for docker 23
and above. The explicit storage driver configuration does not break
docker 20 and older; it works fine if btrfs storage is provided (which
it is in the test).

Starting with docker 23, overlay2 is the default also for btrfs
filesystems, and the btrfs driver is opt-in. See
https://docs.docker.com/engine/release-notes/23.0/#bug-fixes-and-enhancements-6
and
moby/moby#42661

Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
@t-lo t-lo force-pushed the t-lo/portage-stable-docker-24 branch from ed919f4 to 60615e2 Compare October 25, 2023 13:01
@t-lo t-lo marked this pull request as ready for review October 25, 2023 13:03
@t-lo t-lo requested a review from a team October 25, 2023 13:03
@t-lo t-lo merged commit 0279ff3 into flatcar-master Oct 25, 2023
1 of 2 checks passed
@t-lo t-lo deleted the t-lo/portage-stable-docker-24 branch October 25, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants