Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kola: Skip devcontainer test if not available #443

Open
wants to merge 1 commit into
base: flatcar-master
Choose a base branch
from
Open

kola: Skip devcontainer test if not available #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions kola/tests/util/devcontainer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ function download_dev_container_image {
version=$(source /usr/share/flatcar/release; echo "${FLATCAR_RELEASE_VERSION}")
image_url=$(process_template '{{ .ImageDirectoryURLTemplate }}/flatcar_developer_container.bin.bz2' "${arch}" "${version}")

if [ "$(curl -I --retry-delay 1 --retry 60 --retry-connrefused --retry-max-time 60 --connect-timeout 20 -L -s -o /dev/null -w "%{http_code}" "${image_url}")" = 404 ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the image_url is built from some well-known variables (arch, version, etc.) - I'm wondering if we can't use the SkipFunc?
Otherwise we don't really skip the test, we just make it pass right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we don't skip it because I didn't want to duplicate the URL assembly but if wanted, we can do this. SkipFunc is not enough because we need the version ID from the image's os-release file. I can rework this to skip the test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just that Mantle has already a logic to skip the test and it's supported by the TAP format - we could see to leverage it (or use the SkipFunc).
As a trade-off, we could return a well-known return code or string, when the script is executed if we're getting this value: c.Skip

echo "Skipping test because the devcontainer is not available" >&2
exit 0
fi

echo "Fetching developer container from ${image_url}"
# Stolen from copy_from_buildcache in ci_automation_common.sh. Not
# using --output-dir option as this seems to be quite a new addition
Expand Down