Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump go version #319

Merged
merged 3 commits into from
Apr 13, 2022
Merged

build: bump go version #319

merged 3 commits into from
Apr 13, 2022

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Apr 11, 2022 •
edited
Loading

otherwise it fails in #318 with:

type reflect.StructField has no field or method IsExported

Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com

NB: GH action always pulls the latest (currently 1.18)

tormath1 added 2 commits April 11, 2022 16:55
@tormath1
build: bump go version
bd083eb 
otherwise it fails with:
```
type reflect.StructField has no field or method IsExported
```

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
mod: go mod edit -go=1.17
dbccd07 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 requested review from jepio and a team April 11, 2022 14:58
@tormath1 tormath1 self-assigned this Apr 11, 2022
@tormath1 tormath1 mentioned this pull request Apr 11, 2022
Merged
2 tasks
@tormath1
mod: go mod tiy && go mod vendor
a9c9173 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
jepio
jepio approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this was tested with at least one of the kola jobs.

@tormath1
Copy link
Contributor Author

tormath1 commented Apr 13, 2022 •
edited
Loading

LGTM if this was tested with at least one of the kola jobs.

Thanks - testing a cl.basic there: http://jenkins.infra.kinvolk.io:8080/job/os/job/kola/job/qemu_uefi/144

EDIT: Jenkins test passed.

@tormath1 tormath1 merged commit 4f474f3 into flatcar-master Apr 13, 2022
@tormath1 tormath1 deleted the tormath1/bump-go branch April 13, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepio jepio jepio approved these changes

Assignees

@tormath1 tormath1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tormath1 @jepio