azure private networking #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
reviewed
Feb 18, 2022
pothos
reviewed
Feb 18, 2022
pothos
reviewed
Feb 18, 2022
When preparing a flight, network resources are created. Later when creating an instance, we need to lookup the resources again in order to pass the Subnet struct to the NIC creation function. Instead of performing the lookup every time an instance is created, store it in the flight and cluster structs.
The user can now pass the name of an external vnet/subnet to use when creating instances. If the subnet name is missing, 'default' is assumed. The validation of the parameter is performed after creating resource group and storage account so in case of failure we need to destroy them. The easiest way to accomplish that is by calling the Flight or Cluster destroy methods.
… marketplace Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Kola now supports creating instances inside an existing virtual network. When combined with Azure VPN gateway, or when running tests from within that virtual network, it is possible to access instances via private ip addresses. We signal this by setting an empty public IP name, which shortcuts the lookup of the public ip address and causes it to return the private IP. We still need to give the instances a public IP for outbound networking.
jepio
force-pushed
the
jepio/azure-private-networking
branch
from
b6e0dfd to
4d8d875
Compare
krnowak
approved these changes
Feb 18, 2022
Co-authored-by: Krzesimir Nowak <knowak@microsoft.com>
jepio
force-pushed
the
jepio/azure-private-networking
branch
from
bf52b45 to
d14e493
Compare
krnowak
approved these changes
Feb 18, 2022
|
@pothos any further suggestions before merging? |
no, all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure private networking
Add kola support for creating instances in an existing virtual network/subnet, and addressing them using private IP addresses. This assumes that we are either also located in the specified virtual network or can otherwise access it via VPN.
The
--azure-use-private-ipsoption only makes sense when used together with the--azure-vnet-subnet-name, as otherwise kola creates the vnet and it won't be peered or have a VPN configured.How to use
Testing done
Ran the command from the "how-to-use" section.
changelog/directory (user-facing change, bug fix, security fix, update)