etcd: enable v2 support for various tests
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 25, 2021 11:31
with the upgrade to etcd/v3 by default, `flannel` tests are failing because it does not support etcd/v3 at the moment. we pin the `etcdctl` version to `V2` and run `etcd-member` with `v2` support. Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
with the upgrade to etcd/v3, locksmith still relies on etcd/v2. While `locksmith` is being upgraded, we enable the `etcd` v2 support. Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
since we are testing v2 backup, we need to enable v2 support in case we are running etcd v3. Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
14 tasks
krnowak
reviewed
Aug 25, 2021
kola/tests/etcd/discovery.go
Outdated
| @@ -113,7 +121,7 @@ func etcdMemberV2BackupRestore(c cluster.TestCluster) { | |||
|
|
|||
| backup_to="$(mktemp -d)" | |||
|
|
|||
| sudo etcdctl backup --data-dir=/var/lib/etcd \ | |||
| sudo -E etcdctl backup --data-dir=/var/lib/etcd \ | |||
There was a problem hiding this comment.
Maybe limit it to just one env var?
Suggested change
| sudo -E etcdctl backup --data-dir=/var/lib/etcd \ | |
| sudo --preserve-env=ETCD_ENABLE_V2 etcdctl backup --data-dir=/var/lib/etcd \ |
There was a problem hiding this comment.
cool, did not know that ! Thanks.
krnowak
approved these changes
Aug 25, 2021
added 2 commits
August 25, 2021 15:51
if we don't provide the `--preserve-env` flag, we do not preserve the environment variable `ETCDCTL_API` in sudo mode. `backup` is ran against `etcdctl` v3 which does not know this command. Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
`Error fetching backend: UDP backend is not supported on this architecture` Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
force-pushed
the
tormath1/fix-flannel-tests
branch
from
816bf24 to
9eb5b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we prepare the landing of flatcar-archive/coreos-overlay#1179 which brings
etcd/v3by default.flanneldoes not support yetetcd/v3so we enablev2supportlocksmithis WIP to supportetcd/v3cl.etcd-member.v2-backup-restoretest the actual behavior ofv2backup so it requiresv2to be enabledv2support is done through this option: https://etcd.io/docs/v3.5/op-guide/configuration/#--enable-v2Testing done
Tested against the current
alphaand the image provided in flatcar-archive/coreos-overlay#1179 (arm64 in progress...)