Packet: Set OEM ID for PXE boot network setup #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without any OEM information the default DHCP setup for one of the interfaces works ok and is required to work inside the initramfs but later after the initramfs the network setup provided by the metadata server should be used. This is what is currently used in the real PXE installation processes and should be covered by our CI. It is also needed as soon as there is a change that assumes the network setup according to the metadata server is done after the initramfs.
sayanchowdhury
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without any OEM information the default DHCP setup for one of the
interfaces works ok and is required to work inside the initramfs
but later after the initramfs the network setup provided by the
metadata server should be used. This is what is currently used in the
real PXE installation processes and should be covered by our CI. It is
also needed as soon as there is a change that assumes the network setup
according to the metadata server is done after the initramfs.
How to use
Run kola tests
Testing done
None