Skip to content

Commit

Permalink
Merge pull request #87 from flatcar-linux/sayan/exclude-docker-torcx-…
Browse files Browse the repository at this point in the history
…tests-edge

kola: Exclude Docker torcx tests for Edge Channel
  • Loading branch information
sayanchowdhury authored Apr 16, 2020
2 parents 3e00a64 + e72e475 commit 72b7219
Showing 1 changed file with 3 additions and 33 deletions.
36 changes: 3 additions & 33 deletions kola/tests/docker/torcx_docker_flag.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,8 @@
package docker

import (
"fmt"
"regexp"
"strings"

"github.com/coreos/go-semver/semver"
"github.com/coreos/mantle/kola/cluster"
"github.com/coreos/mantle/kola/register"
"github.com/coreos/mantle/platform"
Expand All @@ -40,7 +37,8 @@ storage:
inline: yes
mode: 0644
`),
Distros: []string{"cl"},
Distros: []string{"cl"},
ExcludeChannels: []string{"edge"},
})
register.Register(&register.Test{
Run: dockerTorcxFlagFileCloudConfig,
Expand All @@ -54,22 +52,13 @@ write_files:
`),
Distros: []string{"cl"},
ExcludePlatforms: []string{"qemu-unpriv"},
ExcludeChannels: []string{"edge"},
})
}

func dockerTorcxFlagFile(c cluster.TestCluster) {
m := c.Machines()[0]

// Skip the test in case of Edge, e.g. "xxxx.99.z"
ver := strings.Split(string(c.MustSSH(m, "grep ^VERSION_ID= /etc/os-release")), "=")[1]
semver, err := parseCLVersion(ver)
if err != nil {
c.Fatalf("cannot parse Flatcar version: %v", err)
}
if semver.Minor == int64(99) {
c.Skipf("skipping tests for Edge %s", semver.String())
}

// flag=yes
checkTorcxDockerVersions(c, m, `^1\.12$`, `^1\.12\.`)

Expand All @@ -85,16 +74,6 @@ func dockerTorcxFlagFile(c cluster.TestCluster) {
func dockerTorcxFlagFileCloudConfig(c cluster.TestCluster) {
m := c.Machines()[0]

// Skip the test in case of Edge, e.g. "xxxx.99.z"
ver := strings.Split(string(c.MustSSH(m, "grep ^VERSION_ID= /etc/os-release")), "=")[1]
semver, err := parseCLVersion(ver)
if err != nil {
c.Fatalf("cannot parse Flatcar version: %v", err)
}
if semver.Minor == int64(99) {
c.Skipf("skipping tests for Edge %s", semver.String())
}

// cloudinit runs after torcx
if err := m.Reboot(); err != nil {
c.Fatalf("couldn't reboot: %v", err)
Expand All @@ -115,12 +94,3 @@ func checkTorcxDockerVersions(c cluster.TestCluster, m platform.Machine, expecte
c.Errorf("version %s did not match %q", ver, expectedVerRE)
}
}

func parseCLVersion(input string) (*semver.Version, error) {
version, err := semver.NewVersion(input)
if err != nil {
return nil, fmt.Errorf("parsing os-release semver: %v", err)
}

return version, nil
}

0 comments on commit 72b7219

Please sign in to comment.