-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
networkd: no networkd handling of tun IFs #6
networkd: no networkd handling of tun IFs #6
Conversation
This change prevents networkd interference with virtual/tunnel devices for IPSEC (vti*), docker's virtual interfaces (docker*), and Calico's virtual interfaces (cali*). This fixes issues introduced by networkd interference we observed with IPSEC interfaces in particular (tunnel virtual IP being de-configured and tunnel route torn down at interface activation time). It also aims to prevent future issues with docker and Calico. Signed-off-by: Thilo Fromm <thilo@kinvolk.io>
Great! But I'm not sure about the And I think other configs like |
Oh nice, so for Docker we already have a solution. Will remove the file from my pr tomorrow. Wrt. overlay vs. init repo, I'm open for considerations. |
Signed-off-by: Thilo Fromm <thilo@kinvolk.io>
I've updated the pull request to exclude My motivation to have the fix in the |
Any chance of getting this into one of the next releases (I realize I just missed a release train)? I don't think the change will have any negative effects on existing use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm still not sure if this init
repo is the correct place for different network files.
Anyway we can change the location later.
These changes are really needed, so I think it's ok to merge.
Since we added several systemd-networkd config files to flatcar-linux/init, we need to also update coreos-init to pull the newest commit of coreos-init. See also flatcar/init#6
Revert "systemd: add module to disable network device renaming"
This change prevents networkd interference with virtual/tunnel
devices for IPSEC (vti*), docker's virtual interfaces (docker*),
and Calico's virtual interfaces (cali*).
This fixes issues introduced by networkd interference we observed
with IPSEC interfaces in particular (tunnel virtual IP being
de-configured and tunnel route torn down at interface activation
time). It also aims to prevent future issues with docker and Calico.
Signed-off-by: Thilo Fromm thilo@kinvolk.io