Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkd: no networkd handling of tun IFs #6

Merged

Conversation

t-lo
Copy link
Member

@t-lo t-lo commented Mar 11, 2019

This change prevents networkd interference with virtual/tunnel
devices for IPSEC (vti*), docker's virtual interfaces (docker*),
and Calico's virtual interfaces (cali*).

This fixes issues introduced by networkd interference we observed
with IPSEC interfaces in particular (tunnel virtual IP being
de-configured and tunnel route torn down at interface activation
time). It also aims to prevent future issues with docker and Calico.

Signed-off-by: Thilo Fromm thilo@kinvolk.io

This change prevents networkd interference with virtual/tunnel
devices for IPSEC (vti*), docker's virtual interfaces (docker*),
and Calico's virtual interfaces (cali*).

This fixes issues introduced by networkd interference we observed
with IPSEC interfaces in particular (tunnel virtual IP being
de-configured and tunnel route torn down at interface activation
time). It also aims to prevent future issues with docker and Calico.

Signed-off-by: Thilo Fromm <thilo@kinvolk.io>
@dongsupark
Copy link
Member

Great!

But I'm not sure about the docker.network, because it will conflict with
the same file in coreos-overlay.

And I think other configs like flannel.network have been added to coreos-overlay instead of the common init repo.
I'm not sure why. Need to track down its git history.

@t-lo
Copy link
Member Author

t-lo commented Mar 11, 2019

Oh nice, so for Docker we already have a solution. Will remove the file from my pr tomorrow.

Wrt. overlay vs. init repo, I'm open for considerations.

Signed-off-by: Thilo Fromm <thilo@kinvolk.io>
@t-lo
Copy link
Member Author

t-lo commented Mar 12, 2019

I've updated the pull request to exclude docker.network and to include cni.network which solves an issue ignored by CoreOS upstream: coreos/bugs#1678

My motivation to have the fix in the init repo is because the config file which causes the network interference in the first place, zz-default.network, is part of the init repo, too.

@t-lo
Copy link
Member Author

t-lo commented Mar 13, 2019

Any chance of getting this into one of the next releases (I realize I just missed a release train)? I don't think the change will have any negative effects on existing use cases.

Copy link
Member

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm still not sure if this init repo is the correct place for different network files.
Anyway we can change the location later.
These changes are really needed, so I think it's ok to merge.

@dongsupark dongsupark merged commit 47b635f into flatcar-master Mar 14, 2019
@dongsupark dongsupark deleted the t-lo/no-networkd-on-ipsec-docker-calico-ifs branch March 14, 2019 11:18
dongsupark pushed a commit to flatcar-archive/coreos-overlay that referenced this pull request Mar 14, 2019
Since we added several systemd-networkd config files to
flatcar-linux/init, we need to also update coreos-init to pull
the newest commit of coreos-init.

See also flatcar/init#6
jepio pushed a commit that referenced this pull request Feb 21, 2022
Revert "systemd: add module to disable network device renaming"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants