Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: kubevirt: add documentation #333

Merged
merged 1 commit into from
May 30, 2024
Merged

docs: kubevirt: add documentation #333

merged 1 commit into from
May 30, 2024

Conversation

ader1990
Copy link
Contributor

Added how to on downloading the KubeVirt oem image and how to create a KubeVirt VM with userdata in both supported formats:

  • ConfigDrive
  • Ignition

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-333.westeurope.1.azurestaticapps.net

@ader1990
Copy link
Contributor Author

I am not sure if the vms is the correct place to put the docs, as KubeVirt acts more like a cloud manager?

tormath1
tormath1 reviewed May 21, 2024
View reviewed changes
content/docs/latest/installing/vms/kubevirt.md Outdated Show resolved Hide resolved
content/docs/latest/installing/vms/kubevirt.md Outdated Show resolved Hide resolved
content/docs/latest/installing/vms/kubevirt.md Outdated Show resolved Hide resolved
content/docs/latest/installing/vms/kubevirt.md Outdated Show resolved Hide resolved
content/docs/latest/installing/vms/kubevirt.md Show resolved Hide resolved
content/docs/latest/installing/vms/kubevirt.md Outdated Show resolved Hide resolved
ader1990
ader1990 commented May 21, 2024
View reviewed changes
Copy link
Contributor Author

@ader1990 ader1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tormath1 thanks for the review (will address the comments asap). I will wait a little for the release to happen before the merge.

content/docs/latest/installing/vms/kubevirt.md Outdated Show resolved Hide resolved
content/docs/latest/installing/vms/kubevirt.md Outdated Show resolved Hide resolved
@ader1990
Copy link
Contributor Author

@tormath1 Thank you for the review, hopefully I got all the comments addressed. Waiting for the release to happen tomorrow so that I can merge the PR.

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-333.westeurope.1.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-333.westeurope.1.azurestaticapps.net

tormath1
tormath1 previously approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for the release now. Thanks!

content/docs/latest/installing/vms/kubevirt.md Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request May 22, 2024
Closed
@ader1990
docs: kubevirt: add documentation
adaeba9 
Added how to on downloading the KubeVirt OEM image and how to
create a KubeVirt VM with userdata in both supported formats:

* cloud-Init
* Ignition

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-333.westeurope.1.azurestaticapps.net

@ader1990 ader1990 self-assigned this May 29, 2024
@ader1990 ader1990 requested a review from tormath1 May 29, 2024 14:00
@ader1990 ader1990 merged commit a82cb1d into master May 30, 2024
2 checks passed
@tormath1 tormath1 mentioned this pull request May 30, 2024
Open
2 tasks
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tormath1 tormath1 tormath1 approved these changes

Assignees

@ader1990 ader1990

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ader1990 @tormath1