Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/releases/stable, beta: fix torcx removal warning #289

Merged
merged 1 commit into from
Nov 22, 2023
Merged

data/releases/stable, beta: fix torcx removal warning #289

merged 1 commit into from
Nov 22, 2023

Conversation

t-lo
Copy link
Member

@t-lo t-lo commented Nov 22, 2023

This small change replaces the :warning: semantic emoji - which does not render in Hugo and hence appears as a literal :warning: string - with the UTF8 emoji ⚠️.

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-289.westeurope.1.azurestaticapps.net

@pothos
Copy link
Member

pothos commented Nov 22, 2023

To persist it we need to update the github releases, too

@pothos
Copy link
Member

pothos commented Nov 22, 2023

Done, running update-flatcar-versions.sh should give the same result now

pothos
pothos approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the old :warning: will still be used in the rss/json feed unless we rerun update-flatcar-versions but since this triggers rss readers to see a new entry it's ok to leave it as is.

@t-lo
Copy link
Member Author

t-lo commented Nov 22, 2023

Thank you Kai!

@t-lo t-lo merged commit 282eca2 into master Nov 22, 2023
2 checks passed
@t-lo t-lo deleted the t-lo/fix-trocx-removal-warning branch November 22, 2023 11:43
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Closed
miao0miao pushed a commit to miao0miao/flatcar-website that referenced this pull request Mar 7, 2024
@tormath1
Merge pull request flatcar#289 from flatcar/tormath1/customizing-docker
a5499a6 
customizing-docker: migrate to butane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pothos pothos pothos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-lo @pothos