Exclude profiles/repo_name when syncing with Gentoo #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewi
changed the title
This has less disk churn and allows us to exclude certain files. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
We want to call our own repo portage-stable (or soon gentoo-subset) so stop setting this file back to "gentoo". It wasn't an issue before because we set the name to portage-stable in layout.conf, but you're not supposed to set it there any more. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
force-pushed
the
chewi/exclude-repo-name
branch
from
4d773b3
to
22eec64
Compare
It was failing due to set -u. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
changed the title
tormath1
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude profiles/repo_name when syncing with Gentoo
We want to call our own repo portage-stable (or soon gentoo-subset) so stop setting this file back to "gentoo". It wasn't an issue before because we set the name to portage-stable in layout.conf, but you're not supposed to set it there anymore.
The change achieves this with rsync, which also gives the benefit of less disk churn.
I did consider doing this exclusion via portage-stable-packages-list, but one line is passed to sync-with-gentoo at a time, which doesn't really allow for exclusions. sync-with-gentoo already has specific rules for certain directories, so this doesn't seem so bad.
How to use
Try it as usual and see whether repo_name changes.
Testing done
I have manually run sync-with-gentoo locally to see the effect on repo_name and other files.