platform/conf: add Butane config support
#318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
force-pushed
the
tormath1/butane
branch
from
e29f782 to
6ca2617
Compare
Merged
tormath1
force-pushed
the
tormath1/butane
branch
from
6ca2617 to
46b89d6
Compare
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
butane config will be translated to Ignition >= 3.3.0 before following the regular Ignition process. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
it makes the configuration lighter - for example with luks test, it's not required to define the "mount" system unit because it's generated by Butane. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/butane
branch
from
46b89d6 to
b3f4195
Compare
|
CI passed. |
pothos
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we provide
conf.Butaneto define userdata:it should be used whenever we want to generate Ignition configuration, in place of CLC - except if we want to test specific CLC of course. It should support other
versionof Butane Flatcar's variant as long as we keep the vendor in sync with the upstream dependency since it's butane who takes care of finding the right translator for a given configuration.1.1.0-experimentaldoes not work currently because it generates Ignition-3.4.0 which is not supported by Ignition neither Flatcar.Note for reviewers
platform/conf: use coreos/ignition for ignition/v3is required because CLC generates an Ignitiontypesdefined inflatcar-linux/ignition, so we need to keepflatcar-linux/ignition.changelog/directory (user-facing change, bug fix, security fix, update)