This repository has been archived by the owner on May 30, 2023. It is now read-only.
Drop app-emulation/rkt and app-admin/kubelet-wrapper #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rkt container runtime is deprecated and not used anymore except for the kubelet-wrapper script. This script can't be ported to Docker because it is used by the user with rkt-specific arguments and it is only a wrapper around the deprecated hyperkube images (and has been broken for the last K8s releases). The recommended way is to run the kubelet binary directly on the host.
sayanchowdhury
approved these changes
Apr 22, 2021
tormath1
added a commit
to flatcar/mantle
that referenced
this pull request
Dec 1, 2021
`rkt` is no more shipped into the OS since flatcar-archive/coreos-overlay#965, let's remove this tests. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rkt container runtime is deprecated and not used anymore except
for the kubelet-wrapper script. This script can't be ported to Docker
because it is used by the user with rkt-specific arguments and it is
only a wrapper around the deprecated hyperkube images (and has been
broken for the last K8s releases). The recommended way is to run the
kubelet binary directly on the host.
How to use
Merge after #958 and flatcar/mantle#170 and flatcar/mantle#169
Testing done
here