This repository has been archived by the owner on May 30, 2023. It is now read-only.
app-admin/etcd-wrapper: use docker for the etcd service and drop etcd-wrapper #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
force-pushed
the
kai/remove-rkt
branch
3 times, most recently
from
d584a55 to
8cde1a7
Compare
pothos
changed the title
pothos
force-pushed
the
kai/remove-rkt
branch
3 times, most recently
from
44f1409 to
39a7cd2
Compare
pothos
force-pushed
the
kai/remove-rkt
branch
10 times, most recently
from
6712ada to
9492621
Compare
pothos
force-pushed
the
kai/remove-rkt
branch
7 times, most recently
from
b8873a6 to
d4d4974
Compare
pothos
force-pushed
the
kai/remove-rkt
branch
5 times, most recently
from
2ff06e1 to
0e45695
Compare
pothos
force-pushed
the
kai/remove-rkt
branch
4 times, most recently
from
f8336cf to
392919e
Compare
pothos
force-pushed
the
kai/remove-rkt
branch
4 times, most recently
from
a9c9410 to
dabacdb
Compare
Since rkt is deprecated we need to run the etcd container with Docker or Podman. The etcd-wrapper script is based on rkt arguments and can't be used in a compatible way but we cannot remove it since ct explicitly uses it in the ExecStart directive when writing out a drop-in file once etcd settings are given in a Container Linux Config. A better way to run the Flannel/etcd container image is Podman because Flannel depends on etcd but wants to be run before Docker so that it can set up the Docker networking. Etcd and Flannel are part of the Container Linux Config specification and thus can't be removed easily. For now we have to resort to running these services with Docker and try to restart Docker for the Flannel options to take effect.
As rkt is deprecated we need to run the Flannel container with Docker or Podman. The flannel-wrapper script is based on rkt arguments and can't be used in a compatible way but we cannot remove it since ct explicitly uses it in the ExecStart directive when writing out a drop-in file once flannel settings are given in a Container Linux Config. A better way to run the Flannel/etcd container image is Podman because Flannel depends on etcd but wants to be run before Docker so that it can set up the Docker networking. Etcd and Flannel are part of the Container Linux Config specification and thus can't be removed easily. For now we have to resort to running these services with Docker and try to restart Docker for the Flannel options to take effect (but that also terminates the etcd and flannel containers, causing the services to restart).
|
Found out that the Kubernetes test failed because I had |
pothos
added a commit
to flatcar/mantle
that referenced
this pull request
Mar 22, 2021
The updated test will only work when flatcar-archive/coreos-overlay#857 is present in the tested version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As rkt is deprecated we need to run the Etcd and Flannel container with Docker
or Podman. The etcd/flannel-wrapper script is based on rkt arguments and
can't be used in a compatible way but we cannot remove it since ct
explicitly uses it in the ExecStart directive when writing out a
drop-in file once flannel settings are given in a Container Linux
Config.
A better way to run the Flannel/etcd container image is Podman because
Flannel depends on etcd but wants to be run before Docker so that it
can set up the Docker networking. Etcd and Flannel are part of the
Container Linux Config specification and thus can't be removed easily.
For now we have to resort to running these services with Docker and try
to restart Docker for the Flannel options to take effect (but that also
terminates the etcd and flannel containers, causing the services to
restart).
How to use
Run kola tests for a cloud provider, not QEMU where the tests are excluded
A fix for the Kubernetes test is here: flatcar/mantle#162
Note: From now on it's not possible to specify
Requires=flanneld.servicefordocker.servicebecause that creates a cyclic dependency.Testing done
here