This repository has been archived by the owner on May 30, 2023. It is now read-only.
amazon-ssm-agent: re-add dependency to oem-ec2-compat #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ebuild was missing a call to go_export() which exports GOARCH, and so was
always built for host architecture. While COREOS_GO_VERSION was specified as
go1.12, src_compile() has to use '${EGO}' to make use of it, so we were
building with go1.16 (latest). Upstream builds with 1.12 for this version, so
we will do the same.
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
I think we should also try to install it now instead of leaving it unused. |
|
Sure |
…ges"" Now that the OEM partition is a btrfs partition with compression, we have enough space to install ssm agent. This reverts commit b6abb59. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
and properly include all deps in RDEPEND. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
changed the title
|
@pothos I brought back the dependency and I probed the OEM partition of the AMI to see that it's there. Will try to run CI for it. |
|
Nice, thanks, how much space is left on the OEM partition? |
|
~85MB |
|
Seems the compression pays off, previously it didn't fit Edit: here the stats: 122M binary content gets compressed, resulting in a 37M used filesystem |
pothos
approved these changes
Aug 3, 2021
|
CI green ✔️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amazon-ssm-agent: re-add dependency to oem-ec2-compat
The binaries were too big to fit on our 128MB OEM partition. Now that the OEM partition is compressed-btrfs it fits again, so re-add the dependency to oem-ec2-compat.
The other half of the PR are cross-compilation fixes. The ebuild was not exporting GOARCH and was making use of latest go. When built for arm64, host binaries were produced. The ebuild has been fixed to cross-compile correctly.
Related: flatcar/Flatcar#107
How to use
Testing done
Build tested, and tested that the binaries fit on the OEM partition.