-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hydrabus hardware #21
base: staging
Are you sure you want to change the base?
Conversation
I found some issues with this:
N.B. I'm also working on having serprog/libfrser support in hydrafw, but decided to look at this too... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better, but you missed a few things in splitting the spispeeds table.
N.B. When I dont find anything to complain about codewise I'll post this patchset (likely squashed to one patch) to the flashrom gerrit.
buspirate_spi.c
Outdated
msg_pinfo("It is recommended to upgrade to firmware 6.2 or newer.\n"); | ||
spispeed = 0x4; | ||
} | ||
if(spispeed > 0x07) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is now unnecessary
buspirate_spi.c
Outdated
@@ -424,6 +460,8 @@ int buspirate_spi_init(void) | |||
return 1; | |||
} | |||
|
|||
/* Hydrabus uses different speeds in the same range */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mask is now unnecessary
Change-Id: I621b384dcea42688a7d67c42865c88f1b958654f
Change-Id: I6ac87251ddcb63ffd50d1bd7a5535de59eaad8b2 Signed-off-by: Baldanos <balda@balda.ch>
Change-Id: Idc0a0ffccec92e1c8eb23150dd287119425f5de8 Signed-off-by: Baldanos <balda@balda.ch>
Change-Id: I674ddd125e81c81a5c2b9dab623ba7c83db88fcd Signed-off-by: Baldanos <balda@balda.ch>
Change-Id: I9f44a40090b7746baa4951975bf6cb2c42e381f9
Hi @urjaman ! We just made some more tests and corrected some bugs on the patch, seems to work well using BP and hydrabus. How can I help make it into flashrom ? I made a new branch synced on master (see https://github.com/Baldanos/flashrom), but I don't know how to change this PR to point to the new branch. Let me know if I need to close this one and open a new one. |
Hello, I would very much like to see this patch in the upstream. I've tested @Baldanos branch with HydraBus and various chips and just tested once again the latest version with another chip, W25Q128.V. I can confirm that it works just fine. Please let me know if there is anything I can do to help with this pull request. |
Just in case I compared two dumps, first made with HydraBus and second made with FT2232 chip. They are identical. |
Could you accept this pull request ? It will be very nice to have official support of HydraBus on next version of flashrom |
What's the status on this? I would very much like to use this, too :) |
Could your provide an update on that Pull Request after more than 1 year I confirm it works perfectly |
I have added a How To/Tutorial for that here https://github.com/hydrabus/hydrafw/blob/master/contrib/How%20to%20ReadWrite%20SPIFlash%20with%20FlashROM%20and%20HydraBus.pdf |
This patch adds support for Hydrabus hardware (http://hydrabus.com/).
As it reuses the same commands as the Bus Pirate, only detection code has been changed.
This patch has been tested on Hydrabus firmware revision 8488be1e5231ca5e55c4ba193aebaf1b29abcfd1 and on Bus Pirate hw rev 3.a / firmware 6.1 and 6.2.