chore(Dockerfile): add --package=${RBUILDER_BIN} to fix reth-rbuilder container #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanschneider
requested review from
dvush,
ZanCorDX,
metachris and
ferranbt
as code owners
Benchmark results for
|
| Date (UTC) | 2024-11-21T16:49:33+00:00 |
| Commit | 6309e1c5857bfd74097fdd3cd5be3e553d3b02e5 |
| Base SHA | 70579d128cda94081f1335e3cd3499ff94a7899a |
Significant changes
None
|
lgtm |
barnabasbusa
approved these changes
Nov 21, 2024
liamaharon
reviewed
Nov 21, 2024
liamaharon
approved these changes
Nov 21, 2024
Co-authored-by: liamaharon <liam.aharon@hotmail.com>
grasphoper
pushed a commit
to grasphoper/rbuilder
that referenced
this pull request
Nov 27, 2024
… container (flashbots#250) ## 📝 Summary The addition of `default-members = ["crates/rbuilder"]` in flashbots#244 broke the ability to use `docker build --build-arg RBUILDER_BIN=reth-rbuilder` to build a `reth-rbuilder` container, this should re-enable it. ## 💡 Motivation and Context We're using the `reth-rbuilder` container in kurtosis for Pectra testing. --- ## ✅ I have completed the following steps: * [ ] Run `make lint` * [ ] Run `make test` * [ ] Added tests (if applicable) --------- Co-authored-by: liamaharon <liam.aharon@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The addition of
default-members = ["crates/rbuilder"]in #244 broke the ability to usedocker build --build-arg RBUILDER_BIN=reth-rbuilderto build areth-rbuildercontainer, this should re-enable it.💡 Motivation and Context
We're using the
reth-rbuildercontainer in kurtosis for Pectra testing.✅ I have completed the following steps:
make lintmake test