Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass discard flag to miner from builder, revertible transaction gas used #95

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Pass discard flag to miner from builder, revertible transaction gas used #95

merged 1 commit into from
Aug 9, 2023

Conversation

Wazzymandias
Copy link
Contributor

📝 Summary

  • Miner uses revertible discard transaction flag, updated to pass that in
  • When revertible transactions are enabled, there can be bundles with zero transactions in them - this causes there to be a zero value for gas used

📚 References

@Wazzymandias
Pass discard flag to miner from builder, fix division by zero when re…
db0afb6 
…vert transaction is removed from bundle creating empty bundle with 0 gas used
@Wazzymandias Wazzymandias merged commit 9a7a6ed into main Aug 9, 2023
3 checks passed
@Wazzymandias Wazzymandias deleted the bugfix-pass-revert-flag-to-miner branch August 9, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvush dvush dvush approved these changes

@avalonche avalonche avalonche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wazzymandias @dvush @avalonche