Update for beta 8 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2017 20:57
franzliedke
suggested changes
Sep 5, 2017
src/Listener/AddClientAssets.php
Outdated
| @@ -21,13 +21,13 @@ class AddClientAssets | |||
| */ | |||
| public function subscribe(Dispatcher $events) | |||
| { | |||
| $events->listen(ConfigureWebApp::class, [$this, 'addAssets']); | |||
| $events->listen(Rendering::class, [$this, 'addAssets']); | |||
| } | |||
|
|
|||
| /** | |||
| * @param ConfigureClientView $event | |||
There was a problem hiding this comment.
Please remove the docblock.
| */ | ||
| public function whenUserWillBeSaved(UserWillBeSaved $event) | ||
| public function whenSaving(Saving $event) |
There was a problem hiding this comment.
How about whenSavingUser?
19 tasks
|
Ping @cdk2020. Can you take care of the requested changes here and in flarum/akismet#7? Otherwise I will do it, but I wanted to leave the chance to you. ;) |
|
Sorry @franzliedke completely missed you message. I've fixed it, but styleCI is never happy |
|
@cdk2020 Great, thanks for the quick response. Can you also apply my suggestions here, in the flarum-ext-suspend PR? |
added 2 commits
September 14, 2017 10:19
askvortsov1
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Update for beta 8 * StyleCI :) * docBlock * whenSavingUser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this one took me awhile, I was away from my computer.