Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When open notifications Front end error #1238

Closed
liruitian92 opened this issue Sep 4, 2017 · 5 comments
Closed

When open notifications Front end error #1238

liruitian92 opened this issue Sep 4, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@liruitian92
Copy link

liruitian92 commented Sep 4, 2017

Bug report

Version of Flarum: 0.1.0-beta.7
The webserver you are running: apache, nginx
PHP version: 5.6

Flarum info

Output of "php flarum info", run this in terminal in your Flarum directory.

c:\phpDir\htdocs>php flarum info
Flarum core 0.1.0-beta.7
PHP 5.6.30
Loaded extensions: Core, bcmath, calendar, ctype, date, ereg, filter, ftp, hash, iconv, json, mcrypt, SPL, odbc, pcre, Reflection, session, standard, mysqlnd, tokenizer, zip, zlib, libxml, dom, PDO, openssl, SimpleXML, wddx, xml, xmlreader, xmlwriter, curl, fileinfo, gd, mbstring, mysql, Phar, pdo_mysql, PDO_ODBC, xmlrpc, mhash
EXT flarum-approval v0.1.0-beta.7
EXT flarum-bbcode v0.1.0-beta.5
EXT flarum-emoji v0.1.0-beta.6
EXT flarum-english v0.1.0-beta.7
EXT issyrocks12-filter 1.2.2
EXT flagrow-upload 0.5.7
EXT flarum-flags v0.1.0-beta.7
EXT flarum-likes v0.1.0-beta.6
EXT sijad-links 0.1.0-beta.6
EXT flarum-lock v0.1.0-beta.7
EXT flarum-markdown v0.1.0-beta.5
EXT s9e-mediaembed 0.3.2
EXT flarum-mentions v0.1.0-beta.7
EXT jsthon-simplified-chinese v0.1.0-beta.5
EXT flarum-sticky v0.1.0-beta.7
EXT flarum-subscriptions v0.1.0-beta.6
EXT flarum-suspend v0.1.0-beta.7
EXT flarum-tags v0.1.0-beta.8
EXT issyrocks12-users-list 0.2.2.1

Additional comments

1.user A replay a dicussion
2.admin user can receive a notification
3.admin user delete forever the replay of step1
4.when admin user open the recevie notifications,you can see Front end error

_20170906101528

20170906101729

@luceos
Copy link
Member

luceos commented Sep 4, 2017

What error is logged in storage logs flarum.log?

@liruitian92
Copy link
Author

There is no logs in flarum.log. Following is the sql query result after running notification.
_20170906101204

_20170906101200

@tobyzerner tobyzerner added this to the v0.1.0-beta.8 milestone Sep 6, 2017
@matteocontrini
Copy link
Contributor

I think I'm experiencing the same issue. It seems that when you permanently delete a discussion (or a message?), the notifications related to that discussion generate a client exception.

image

@matteocontrini
Copy link
Contributor

Not sure but this might be the same issue as in #1025

tobyzerner added a commit that referenced this issue Dec 13, 2017
ref #1025 #1238. This should prevent the frontend from crashing when
opening the notifications menu, but we still need to make sure
notifications are deleted properly when subjects are deleted.
@tobyzerner tobyzerner modified the milestones: 0.1.0-beta.8, 0.1.0-beta.9 Mar 3, 2018
@tobyzerner tobyzerner self-assigned this Mar 3, 2018
@tobyzerner tobyzerner modified the milestones: 0.1.0-beta.9, 0.1.0-beta.8 Mar 3, 2018
@tobyzerner
Copy link
Contributor

The frontend issue has been fixed. I have created an issue for the remaining backend cleanup #1380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants