run the convert.sh script by CDK2020 to replace namespaces to be comp… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyzerner
reviewed
Sep 13, 2017
src/Listener/AddClientAssets.php
Outdated
| @@ -21,13 +21,13 @@ class AddClientAssets | |||
| */ | |||
| public function subscribe(Dispatcher $events) | |||
| { | |||
| $events->listen(ConfigureWebApp::class, [$this, 'addAssets']); | |||
| $events->listen(Rendering::class, [$this, 'addAssets']); | |||
| } | |||
|
|
|||
| /** | |||
| * @param ConfigureClientView $event | |||
There was a problem hiding this comment.
Please update this docblock
There was a problem hiding this comment.
Sorry, I'm not sure what it should be instead. New to Flarum.
I see this on the namespace changes thread:
{Event/ConfigureWebApp → Frontend/Event/Rendering}
There was a problem hiding this comment.
No worries! Simply change line 28:
* @param ConfigureClientView $events
to:
* @param Rendering $events
There was a problem hiding this comment.
Oh duh! Think I got it, thanks.
|
Thanks @AakLak :D |
|
Nooo... this should have gone to the |
19 tasks
tobyzerner
pushed a commit
that referenced
this pull request
Sep 13, 2017
#8) * run the convert.sh script by CDK2020 to replace namespaces to be compatible for beta8 * update docbloc to match updated namespace
|
Oops 😳 Fixed, I think |
askvortsov1
pushed a commit
that referenced
this pull request
Mar 11, 2022
#8) * run the convert.sh script by CDK2020 to replace namespaces to be compatible for beta8 * update docbloc to match updated namespace
askvortsov1
pushed a commit
that referenced
this pull request
Mar 11, 2022
… be comp… (#8)" This reverts commit c58b60849f63666211fc47fcea3907fdb520a76b.
askvortsov1
pushed a commit
that referenced
this pull request
Mar 11, 2022
#8) * run the convert.sh script by CDK2020 to replace namespaces to be compatible for beta8 * update docbloc to match updated namespace
askvortsov1
pushed a commit
that referenced
this pull request
May 10, 2022
… be comp… (#8)" This reverts commit efe07bd696b66bf3dbd4a17033747a48f4b154c4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run this script:
https://discuss.flarum.org/d/6573-convert-your-beta-7-compatible-extension-to-work-on-beta-8