Catch stderr from executed commands #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miklezzzz
changed the title
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
miklezzzz
force-pushed
the
executor-add-output
branch
from
fdefd1d
to
e7c26ff
Compare
yalosev
approved these changes
Jul 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates the way executor collects executed commands' stderr.
What this PR does / why we need it
This pr enriches executor's errors (if any) with stderr messages from executed commands (if any). It enables providing more meaningful errors from hooks/scripts than "command failed" to the end user.
Special notes for your reviewer