Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "docker manifest" to publish multi-arch Docker images #1327

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

hakman
Copy link
Contributor

@hakman hakman commented Jul 27, 2020

Description

Multi-arch Docker images are very common these days and allow simplify Kubernetes manifests and deployments in general.
At the moment, flannel publishes the AMD64 image both as $REPO:$TAG and $REPO:$TAG-amd64. Instead of duplicating the AMD64 image, the $REPO:$TAG could be a Docker manifest.

This would allow to de-duplicate a lot the content of https://github.com/coreos/flannel/blob/v0.12.0/Documentation/kube-flannel.yml in a future PR.

Fixes: #1116

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Create multi-arch image instead of duplicating the AMD64 image

@rajatchopra
Copy link
Contributor

Aha! Very useful. About time.
Will test and queue it up for merge.
Thanks.

@hakman hakman force-pushed the multi-arch-manifest branch from 60a4675 to a352879 Compare August 5, 2020 07:22
@hakman
Copy link
Contributor Author

hakman commented Aug 5, 2020

Thanks @rajatchopra. I added a small extra to cover flannel-git also. Will send another PR to squash the flannel manifest later this week.

@electrocucaracha
Copy link

Hey there, I have a Kubespray's PR that is targeting to add Flannel Multi-Arch there but this change will definitely help on that. Hopefully this change gets merged soon.

@hakman
Copy link
Contributor Author

hakman commented Sep 3, 2020

@rajatchopra any chance this can make it into v0.13.0?

@rajatchopra rajatchopra merged commit 0b1012f into flannel-io:master Sep 3, 2020
@Oats87
Copy link
Member

Oats87 commented Sep 3, 2020

LGTM

@hakman
Copy link
Contributor Author

hakman commented Sep 3, 2020

Thanks @rajatchopra :)

@hakman hakman deleted the multi-arch-manifest branch September 4, 2020 13:17
@Nayana-ibm Nayana-ibm mentioned this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from multiple daemon sets to multi-arch manifest
4 participants